oceanbox/Oceanbox.FvcomKit
6
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases 80 Wiki Activity

fix: include edge point in isInsideTriangle #33

Merged
oletytlandsvik merged 2 commits from fix/edge-point-in-cell into main 2025-05-02 13:06:30 +00:00
Conversation 5 Commits 2 Files Changed 1 +2 -16
oletytlandsvik commented 2025-05-02 12:21:44 +00:00 (Migrated from gitlab.com)
Copy Link

When a point is calculated to be on a triangle edge, isInsideTriangle will consider it outside the cell.
This leads to tryGetElement not being able to find the nearest element of such points, even when they are within the graph on an internal edge.

This MR proposes to instead consider edge point "inside" the triangle.

When a point is calculated to be on a triangle edge, `isInsideTriangle` will consider it outside the cell. This leads to `tryGetElement` not being able to find the nearest element of such points, even when they are within the graph on an internal edge. This MR proposes to instead consider edge point "inside" the triangle.
oletytlandsvik commented 2025-05-02 12:21:44 +00:00 (Migrated from gitlab.com)
Copy Link

requested review from @stigrj

requested review from @stigrj
stigrj (Migrated from gitlab.com) approved these changes 2025-05-02 12:21:44 +00:00
oletytlandsvik commented 2025-05-02 12:37:36 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 8715f4d8 - fix: remove unused double precision function

Compare with previous version

added 1 commit <ul><li>8715f4d8 - fix: remove unused double precision function</li></ul> [Compare with previous version](/oceanbox/Oceanbox.FvcomKit/-/merge_requests/32/diffs?diff_id=1345368425&start_sha=c89f35bc6e316ac19d2de4ef35dbb78302881373)
stigrj commented 2025-05-02 13:06:24 +00:00 (Migrated from gitlab.com)
Copy Link

approved this merge request

approved this merge request
stigrj commented 2025-05-02 13:06:30 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit bfb3a8e489

mentioned in commit bfb3a8e489ed60a620b84ac3148ab3ed55c74eb0
stigrj (Migrated from gitlab.com) merged commit bfb3a8e489 into main 2025-05-02 13:06:31 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
stigrj
Labels
Clear labels
customer::all
customer::aqua-kompetanse
customer::bjørøya
customer::cermaq
customer::dnv
customer::framo
customer::lerøy
customer::mowi
customer::novasea
customer::oceanpro
customer::ohs
customer::salmar
customer::scaleaq
customer::stim
customer::synfaring
devel::bug
devel::enhancement
devel::feature
documentation
maps
maps::atlantis
maps::sorcerer
maps::ui
market::demo
market::onboarding
market::presentation
models
models::forecast
models::validation
platform
platform::hpc
platform::k8s
priority
priority::high
priority::low
priority::medium
roadmap
support
support::consulting
support::tech
support::user
tooling
tooling::drifters
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
juselius mrtz oletytlandsvik renovate-bot simkir sondre
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: oceanbox/Oceanbox.FvcomKit#33
Delete Branch "fix/edge-point-in-cell"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?