From 34b67cf6a0848c52f376c88559383dbb76ec32fc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Moritz=20J=C3=B6rg?= <moritz.jorg@oceanbox.io>
Date: Tue, 11 Nov 2025 13:47:18 +0100
Subject: [PATCH] fix(atlantis/sorcerer): Arg does not exist

---
 charts/atlantis/templates/redis.yaml | 15 ++++++++-------
 charts/atlantis/values.yaml          |  3 ++-
 charts/sorcerer/templates/redis.yaml | 15 ++++++++-------
 charts/sorcerer/values.yaml          |  4 +++-
 4 files changed, 21 insertions(+), 16 deletions(-)

diff --git a/charts/atlantis/templates/redis.yaml b/charts/atlantis/templates/redis.yaml
index cd61a9cd..dcff5019 100644
--- a/charts/atlantis/templates/redis.yaml
+++ b/charts/atlantis/templates/redis.yaml
@@ -14,7 +14,6 @@ spec:
   args:
     - --maxmemory=$(MAX_MEMORY)Mi # Graceful memory management (90% of limit)
     - --proactor_threads=1 # Auto-detect CPU cores (optimal threading)
-    - --dir=/data
     - --cluster_mode=emulated
   env:
     - name: MAX_MEMORY
@@ -22,7 +21,7 @@ spec:
         resourceFieldRef:
           resource: limits.memory
           divisor: 1Mi
-  replicas: {{ .Values.redis.replicas| default "1" }}
+  replicas: {{ .Values.redis.replicas | default "1" }}
   resources:
     requests:
       cpu: 150m
@@ -37,17 +36,19 @@ spec:
     port: 6379
   storage:
     requests:
-      storage: {{ .Values.cluster.size | default "1Gi" }}
+      storage: {{ .Values.redis.size | default "1Gi" }}
+  {{- if .Values.redis.backup.enabled }}
   snapshot:
-    # cron: "0 3 * * *" # Default: every day at 03:00
-    # enableOnMasterOnly: false
-    dir: /data
+    dir: /data # Change to s3://redis/prod-atlantis-redis
+    cron: "0 3 * * *" # Default: every day at 03:00
+    enableOnMasterOnly: false
     persistentVolumeClaimSpec:
       accessModes:
       - ReadWriteOnce
       resources:
         requests:
-          storage: {{ .Values.cluster.size | default "1Gi" }}
+          storage: {{ .Values.redis.size | default "1Gi" }}
+  {{- end }}
   podSecurityContext:
     runAsUser: 1000
     fsGroup: 1000
diff --git a/charts/atlantis/values.yaml b/charts/atlantis/values.yaml
index 7ca06457..9bbc5e02 100644
--- a/charts/atlantis/values.yaml
+++ b/charts/atlantis/values.yaml
@@ -1,7 +1,6 @@
 # Default values for Atlantis.
 # This is a YAML-formatted file.
 # Declare variables to be passed into your templates.
-
 replicaCount: 1
 image:
   repository: registry.gitlab.com/oceanbox/poseidon/atlantis
@@ -78,6 +77,8 @@ redis:
   instances: 1
   metrics:
     enabled: false
+  backup:
+    enabled: false
   size: 1Gi
 cluster:
   enabled: true
diff --git a/charts/sorcerer/templates/redis.yaml b/charts/sorcerer/templates/redis.yaml
index 629df31f..f7465d7f 100644
--- a/charts/sorcerer/templates/redis.yaml
+++ b/charts/sorcerer/templates/redis.yaml
@@ -14,7 +14,6 @@ spec:
   args:
     - --maxmemory=$(MAX_MEMORY)Mi
     - --proactor_threads=1
-    - --dir=/data
     - --cluster_mode=emulated
   env:
     - name: MAX_MEMORY
@@ -22,7 +21,7 @@ spec:
         resourceFieldRef:
           resource: limits.memory
           divisor: 1Mi
-  replicas: {{ .Values.redis.replicas| default "1" }}
+  replicas: {{ .Values.redis.replicas | default "1" }}
   resources:
     requests:
       cpu: 150m
@@ -37,17 +36,19 @@ spec:
     port: 6379
   storage:
     requests:
-      storage: {{ .Values.cluster.size | default "1Gi" }}
+      storage: {{ .Values.redis.size | default "1Gi" }}
+  {{- if .Values.redis.backup.enabled }}
   snapshot:
-    # cron: "0 3 * * *" # Default: every day at 03:00
-    # enableOnMasterOnly: false
-    dir: /data
+    dir: /data # Change to s3://redis/prod-atlantis-redis
+    cron: "0 3 * * *" # Default: every day at 03:00
+    enableOnMasterOnly: false
     persistentVolumeClaimSpec:
       accessModes:
       - ReadWriteOnce
       resources:
         requests:
-          storage: {{ .Values.cluster.size | default "1Gi" }}
+          storage: {{ .Values.redis.size | default "1Gi" }}
+  {{- end }}
   podSecurityContext:
     runAsUser: 1000
     fsGroup: 1000
diff --git a/charts/sorcerer/values.yaml b/charts/sorcerer/values.yaml
index 7f2e6544..ccd6a8f0 100644
--- a/charts/sorcerer/values.yaml
+++ b/charts/sorcerer/values.yaml
@@ -72,9 +72,11 @@ persistence:
   # accessMode: ReadWriteMany
 redis:
   enabled: false
+  instances: 1
   metrics:
     enabled: false
-  instances: 1
+  backup:
+    enabled: false
   size: 1Gi
 cluster:
   enabled: false