fix: remove explicit access token from helm-git urls (take 3)

helmfile.d/atlantis.yaml.gotmpl

@@ -3,11 +3,7 @@ bases:
 
 repositories:
 - name: oceanbox
-  {{- if env "MANIFESTS_ACCESS_TOKEN" }}
+  url: "git+https://git:{{ requiredEnv "HELM_GIT_ACCESS_TOKEN" }}@gitlab.com/oceanbox/manifests@charts?ref=main"
-  url: "git+https://git:{{ requiredEnv "MANIFESTS_ACCESS_TOKEN" }}@gitlab.com/oceanbox/manifests@charts?ref=main"
-  {{- else }}
-  url: "git+https://gitlab.com/oceanbox/manifests@charts?ref=main"
-  {{- end }}
 
 commonLabels:
   tier: system

helmfile.d/sorcerer.yaml.gotmpl

@@ -3,11 +3,7 @@ bases:
 
 repositories:
 - name: oceanbox
-  {{- if env "MANIFESTS_ACCESS_TOKEN" }}
+  url: "git+https://git:{{ requiredEnv "HELM_GIT_ACCESS_TOKEN" }}@gitlab.com/oceanbox/manifests@charts?ref=main"
-  url: "git+https://git:{{ requiredEnv "MANIFESTS_ACCESS_TOKEN" }}@gitlab.com/oceanbox/manifests@charts?ref=main"
-  {{- else }}
-  url: "git+https://gitlab.com/oceanbox/manifests@charts?ref=main"
-  {{- end }}
 
 commonLabels:
   tier: system

shell.nix

@@ -37,5 +37,5 @@ pkgs.mkShellNoCC {
   ];
 
   ARGOCD_ENV_CLUSTER_NAME = "oceanbox";
-  MANIFESTS_ACCESS_TOKEN = "glpat-xxx";
+  HELM_GIT_ACCESS_TOKEN = "glpat-xxx";
 }

values/argo/values/argocd.yaml.gotmpl

@@ -178,6 +178,13 @@ repoServer:
   - command:
     - /var/run/argocd/argocd-cmp-server
     image: registry.gitlab.com/oceanbox/manifests/helmfile-cmp:latest
+    env:
+    - name: HELM_GIT_ACCESS_TOKEN
+      valueFrom:
+        secretKeyRef:
+          key: password
+          name: oceanbox-gitops-repo
+          optional: false
     imagePullPolicy: Always
     name: helmfile-cmp
     securityContext: